Skip to content

Fix IRGen and tests to use musttail/swiftasync correctly #36661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 1, 2021

Conversation

varungandhi-apple
Copy link
Contributor

No description provided.

@varungandhi-apple
Copy link
Contributor Author

@swift-ci smoke test

@varungandhi-apple
Copy link
Contributor Author

@swift-ci smoke test Linux

1 similar comment
@varungandhi-apple
Copy link
Contributor Author

@swift-ci smoke test Linux

Copy link
Contributor

@aschwaighofer aschwaighofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@varungandhi-apple
Copy link
Contributor Author

@swift-ci clean smoke test Linux

@varungandhi-apple
Copy link
Contributor Author

@swift-ci smoke test Linux

@varungandhi-apple varungandhi-apple merged commit 70a13aa into swiftlang:main Apr 1, 2021
@varungandhi-apple varungandhi-apple deleted the vg-main branch April 1, 2021 23:51
@benrimmington
Copy link
Contributor

@varungandhi-apple This test is failing on watchsimulator-i386 and windows-x86_64.

IRGen/async/run-call-dynamic-void_to_void.swift:20:14: error: CHECK-LL: expected string not found in input
// CHECK-LL: musttail call swifttailcc void
             ^

@varungandhi-apple
Copy link
Contributor Author

@benrimmington, the watch simulator case should be fixed with this LLVM change. swiftlang/llvm-project#2768 (the automerger needs to get through)

I can fix it for Windows.

@varungandhi-apple
Copy link
Contributor Author

#36720

@benrimmington
Copy link
Contributor

swiftlang/llvm-project#2768 has been reverted in swiftlang/llvm-project#2786

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants