[Actors] Permit non-sendable, escaping closures to be actor-isolated. #36698
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the heuristic that escaping closures cannot be actor-isolated. This is in line with the long term plan for actor isolation, but opens up some holes in the short term because Sendable closures are not enforced throughout the Swift ecosystem. One significant effect of this change is that we will now, statically, fail to detect many cases where actor isolation can be broken.
|
@swift-ci please smoke test |
ktoso
reviewed
Apr 1, 2021
|
|
||
| // CHECK: acceptEscapingAsyncClosure | ||
| // CHECK: closure_expr | ||
| // CHECK-NOT:actor-isolated | ||
| acceptEscapingAsyncClosure { () async in print("hello") } | ||
| // CHEC:actor-isolated |
There was a problem hiding this comment.
typo
Suggested change
| // CHEC:actor-isolated | |
| // CHECK:actor-isolated |
ktoso
approved these changes
Apr 1, 2021
|
@swift-ci please smoke test macOS |
|
@swift-ci please smoke test |
|
@swift-ci please smoke test Linux |
|
@swift-ci please smoke test |
|
@swift-ci please smoke test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the heuristic that escaping closures cannot be actor-isolated.
This is in line with the long term plan for actor isolation, but opens
up some holes in the short term because Sendable closures are not enforced
throughout the Swift ecosystem.
One significant effect of this change is that we will now, statically,
fail to detect many cases where actor isolation can be broken.