Skip to content

[SourceKit/CursorInfo] Report the set of decls referenced in the symbol graph's "declarationFragments" field. #36713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

nathawes
Copy link
Contributor

@nathawes nathawes commented Apr 2, 2021

For each referenced decl, also report whether it is a system symbol and/or SPI, its access level, source language, file path, module name, and parent contexts.

Resolves rdar://75809521

@nathawes
Copy link
Contributor Author

nathawes commented Apr 2, 2021

@swift-ci please test

Copy link
Contributor

@bnbarham bnbarham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nathawes nathawes force-pushed the add-fragment-info-with-symbol-graph branch from 374ead7 to 217dd10 Compare April 2, 2021 04:42
@nathawes
Copy link
Contributor Author

nathawes commented Apr 2, 2021

@swift-ci please test

@swift-ci
Copy link
Contributor

swift-ci commented Apr 2, 2021

Build failed
Swift Test OS X Platform
Git Sha - 217dd1094ec121ac0eeeeab650371ccd35cd3a09

Copy link
Contributor

@QuietMisdreavus QuietMisdreavus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Symbol Graph side looks good. The only thing i would ask for is a doc comment on things like Symbol::getFragmentInfo so i can spend less time squinting at it next time to figure out what it does 🤣 Otherwise i like it!

…ol graph's "declarationFragments" field.

Resolves rdar://75809521
@nathawes nathawes force-pushed the add-fragment-info-with-symbol-graph branch from 217dd10 to 08250f0 Compare April 2, 2021 23:43
@nathawes
Copy link
Contributor Author

nathawes commented Apr 2, 2021

@swift-ci please test and merge

@nathawes
Copy link
Contributor Author

nathawes commented Apr 3, 2021

@swift-ci Please Build Toolchain macOS Platform

1 similar comment
@nathawes
Copy link
Contributor Author

nathawes commented Apr 3, 2021

@swift-ci Please Build Toolchain macOS Platform

@nathawes
Copy link
Contributor Author

nathawes commented Apr 3, 2021

@swift-ci please test macOS

@swift-ci
Copy link
Contributor

swift-ci commented Apr 3, 2021

Build failed
Swift Test OS X Platform
Git Sha - 08250f0

@nathawes
Copy link
Contributor Author

nathawes commented Apr 6, 2021

@swift-ci please test macOS

@nathawes
Copy link
Contributor Author

nathawes commented Apr 6, 2021

@swift-ci Please Build Toolchain macOS Platform

@swift-ci
Copy link
Contributor

swift-ci commented Apr 6, 2021

macOS Toolchain
Download Toolchain
Git Sha - 08250f0

Install command
tar -zxf swift-PR-36713-932-osx.tar.gz --directory ~/

@nathawes nathawes merged commit 6ca5b32 into swiftlang:main Apr 6, 2021
@nathawes nathawes deleted the add-fragment-info-with-symbol-graph branch April 6, 2021 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants