[swift-api-extract] BumpPtrAllocate API structs #36727
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix a bug that pointers to ObjCInterfaces can be invalid when std vector expended. Now allocate all the interfaces in BumpPtrAllocator so the pointers to APIs are always valid as long as API class is alive. rdar://76155450
|
@swift-ci Please smoke test |
|
windows failure is not related. |
nkcsgexi
approved these changes
Apr 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a bug that pointers to ObjCInterfaces can be invalid when std vector
expended. Now allocate all the interfaces in BumpPtrAllocator so the
pointers to APIs are always valid as long as API class is alive.
rdar://76155450
Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
rdar://76155450