Skip to content

Disable mandatory-copy-propagation (-Onone only) #36739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 3, 2021

Conversation

atrick
Copy link
Contributor

@atrick atrick commented Apr 3, 2021

This feature degrades the debugging experience and causes a large
number of unit test failures.

These were both known issues, but our planned debugger improvements
won't be ready for a while. Until then, we'll leave the feature under
a compiler option, and developers can adopt it at there own speed for
now when they are ready to fix lifetime issues in their code.

rdar://76177280 (Disable mandatory-copy-propagation (-Onone only))

This feature degrades the debugging experience and causes a large
number of unit test failures.

These were both known issues, but our planned debugger improvements
won't be ready for a while. Until then, we'll leave the feature under
a compiler option, and developers can adopt it at there own speed for
now when they are ready to fix lifetime issues in their code.

rdar://76177280 (Disable mandatory-copy-propagation (-Onone only))
@atrick
Copy link
Contributor Author

atrick commented Apr 3, 2021

@swift-ci test

@swift-ci
Copy link
Contributor

swift-ci commented Apr 3, 2021

Build failed
Swift Test OS X Platform
Git Sha - b1b2eff

@atrick
Copy link
Contributor Author

atrick commented Apr 3, 2021

@swift-ci clean test

@swift-ci
Copy link
Contributor

swift-ci commented Apr 3, 2021

Build failed
Swift Test Linux Platform
Git Sha - b1b2eff

@atrick
Copy link
Contributor Author

atrick commented Apr 3, 2021

@swift-ci test linux

@swift-ci
Copy link
Contributor

swift-ci commented Apr 3, 2021

Build failed
Swift Test OS X Platform
Git Sha - b1b2eff

@atrick
Copy link
Contributor Author

atrick commented Apr 3, 2021

This test failure is to be blocking other PR's too: Swift(iphonesimulator-x86_64).IDE.complete_where_clause.swift

@atrick
Copy link
Contributor Author

atrick commented Apr 3, 2021

@swift-ci smoke test macOS

@tkremenek
Copy link
Member

I reverted the issue causing the test failure:

#36743

@tkremenek tkremenek merged commit 45ab4f4 into swiftlang:main Apr 3, 2021
@atrick atrick deleted the disable-mandatory-copyprop branch April 3, 2021 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants