Skip to content

[CSGen] Removing code that was only necessary for failure diagnostics #36792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 12, 2021
Merged

[CSGen] Removing code that was only necessary for failure diagnostics #36792

merged 1 commit into from
Apr 12, 2021

Conversation

LucianoPAlmeida
Copy link
Contributor

Failure diagnostics is long gone, and by the comment over this code that was the only reason for it.
So we just removing it =]

@LucianoPAlmeida LucianoPAlmeida requested a review from xedin April 7, 2021 02:44
@LucianoPAlmeida
Copy link
Contributor Author

@swift-ci Please smoke test

xedin
xedin approved these changes Apr 7, 2021
View reviewed changes
Copy link
Contributor

@xedin xedin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I think code completion shouldn’t rely on this behavior anymore either.

@LucianoPAlmeida
Copy link
Contributor Author

@swift-ci Please test Windows Platform

@LucianoPAlmeida
Copy link
Contributor Author

@xedin Windows build is failing in all PRs. Could we land this anyways or better wait for it?

@xedin
Copy link
Contributor

xedin commented Apr 7, 2021

@rintaro @nathawes Do you have any concerns about removing this? Is there anything in code completion which would still try to re-typecheck a closure sub-expression?

@xedin
Copy link
Contributor

xedin commented Apr 7, 2021

If there are no concerns I think we can merge even with Windows failing.

@LucianoPAlmeida
Copy link
Contributor Author

If there are no concerns I think we can merge even with Windows failing.

Awesome =]

@LucianoPAlmeida
Copy link
Contributor Author

@swift-ci Please test Windows Platform

1 similar comment
@LucianoPAlmeida
Copy link
Contributor Author

@swift-ci Please test Windows Platform

@xedin xedin merged commit e507bcf into swiftlang:main Apr 12, 2021
@LucianoPAlmeida LucianoPAlmeida deleted the failure-diagnostics-left branch April 14, 2021 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xedin xedin xedin approved these changes

@rintaro rintaro rintaro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LucianoPAlmeida @xedin @rintaro