Skip to content

[CodeCompletion] Remove test lines that are already run using batch completion #36796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 8, 2021

Conversation

ahoppen
Copy link
Member

@ahoppen ahoppen commented Apr 7, 2021

The test has been migrated to batch completion, there is no need to have individual RUN: lines for new code completion tokens.

As suggested in #36551 (comment). Thanks @rintaro .

…ompletion

The test has been migrated to batch completion, there is no need to have individual `RUN:` lines for new code completion tokens.
@ahoppen ahoppen requested a review from rintaro April 7, 2021 08:50
@ahoppen
Copy link
Member Author

ahoppen commented Apr 7, 2021

@swift-ci Please test

Copy link
Member

@rintaro rintaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ahoppen ahoppen merged commit 6e2338c into swiftlang:main Apr 8, 2021
@ahoppen ahoppen deleted the pr/batch-completion branch April 8, 2021 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants