Replace uses of presumed locations where they do not make sense #36807
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
bnbarham
force-pushed
the
use-original-locs
branch
from
40e88b5 to
df3b08f
Compare
bnbarham
changed the title
|
@swift-ci please test |
|
Build failed |
|
Build failed |
|
Build failed |
bnbarham
force-pushed
the
use-original-locs
branch
from
df3b08f to
4815034
Compare
|
@swift-ci please test |
benlangmuir
reviewed
Apr 8, 2021
bnbarham
force-pushed
the
use-original-locs
branch
2 times, most recently
from
f93f4cc to
925bc33
Compare
|
@swift-ci please test |
|
Build failed |
benlangmuir
reviewed
Apr 9, 2021
Various uses of `getPresumedLineAndColumnForLoc` were likely added when that function was the very misleading name `getLineAndColumn`. Change these to use `getLineAndColumnForBuffer` instead where appropriate, ie. we want the underlying file rather than the location to display to the user. There were also some cases where the buffer identifier had been swapped to use the display name instead, under the assumption that the presumed location was needed. Updated those as well. SingleRawComment: Lines are only used when merging comments, where the original location is fine to use. Index: Doesn't store the file set in #sourceLocation, so using the presumed line would end up pointing to a location that makes no sense. Editor functionality: Formatting and refactoring are on the current file. Using the presumed location would result in incorrect replacements.
bnbarham
force-pushed
the
use-original-locs
branch
from
925bc33 to
20f45ec
Compare
|
@swift-ci please test |
|
Build failed |
|
@swift-ci please test Linux platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various uses of
getPresumedLineAndColumnForLocwere likely added whenthat function was the very misleading name
getLineAndColumn. Changethese to use
getLineAndColumnForBufferinstead where appropriate, ie.we want the underlying file rather than the location to display to the
user.
There were also some cases where the buffer identifier had been swapped
to use the display name instead, under the assumption that the presumed
location was needed. Updated those as well.
SingleRawComment: Lines are only used when merging comments, where the
original location is fine to use.
Index: Doesn't store the file set in #sourceLocation, so using the
presumed line would end up pointing to a location that makes no sense.
Editor functionality: Formatting, refactoring, and live diagnostics are
all for the current file. Using the presumed location would either
result in incorrect refactorings or missing errors.