Skip to content

[build-script] Fix tests that assertRaises incorrectly #36809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 8, 2021
Merged

[build-script] Fix tests that assertRaises incorrectly #36809

merged 1 commit into from
Apr 8, 2021

Conversation

porglezomp
Copy link
Contributor

@porglezomp porglezomp commented Apr 8, 2021 •
edited
Loading

This is a follow-up to #36790

@porglezomp porglezomp requested a review from edymtt April 8, 2021 08:02
@porglezomp
Copy link
Contributor Author

@swift-ci please smoke test

@porglezomp
Copy link
Contributor Author

@swift-ci please smoke test macOS Platform

@edymtt
Copy link
Contributor

edymtt commented Apr 8, 2021

Thanks for going through all the instances!

@porglezomp porglezomp merged commit 35f6e58 into swiftlang:main Apr 8, 2021
@porglezomp porglezomp deleted the test-more-thorough branch April 8, 2021 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edymtt edymtt edymtt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@porglezomp @edymtt