Skip to content

[IRGen] Don't use extended encoding for async @objc protocol methods. #36827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 9, 2021
Merged

[IRGen] Don't use extended encoding for async @objc protocol methods. #36827

merged 1 commit into from
Apr 9, 2021

Conversation

varungandhi-apple
Copy link
Contributor

It should only be used for @objc classes.

@varungandhi-apple
Copy link
Contributor Author

@swift-ci smoke test

@varungandhi-apple
Copy link
Contributor Author

@swift-ci smoke test macOS

@varungandhi-apple
Copy link
Contributor Author

varungandhi-apple commented Apr 9, 2021 •
edited
Loading

Test failure perhaps due to #36688 . Seems totally unrelated to this PR.

@varungandhi-apple
Copy link
Contributor Author

@swift-ci smoke test macOS

@varungandhi-apple varungandhi-apple merged commit 6c47454 into swiftlang:main Apr 9, 2021
@varungandhi-apple varungandhi-apple deleted the vg-objc-proto-no-extended-encoding branch April 9, 2021 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeash mikeash mikeash approved these changes

@DougGregor DougGregor Awaiting requested review from DougGregor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@varungandhi-apple @mikeash