[CMake] Unbreak minimal Swift builds #36841
Conversation
|
@swift-ci please test |
|
Build failed |
|
Actually, this doesn't fix the test suite. I think the "right" fix is a CMake generated header file. |
|
Build failed |
|
@swift-ci please clean test |
|
Build failed |
|
Build failed |
|
@swift-ci please smoke test |
1 similar comment
|
@swift-ci please smoke test |
|
@swift-ci please smoke test linux |
|
Hi @DougGregor – What's the plan here? I see that the original pull request has been reverted but I'd imagine that you plan a second attempt at default importing the concurrency module, right? |
|
Rebased on top of @DougGregor's second attempt. @swift-ci please smoke test |
| @@ -274,7 +274,8 @@ namespace swift { | |||
| bool EnableInferPublicSendable = false; | |||
|
|
|||
| /// Disable the implicit import of the _Concurrency module. | |||
| bool DisableImplicitConcurrencyModuleImport = false; | |||
| bool DisableImplicitConcurrencyModuleImport = | |||
| !SWIFT_ENABLE_EXPERIMENTAL_CONCURRENCY; | |||
There was a problem hiding this comment.
Would it be easier to check SWIFT_ENABLE_EXPERIMENTAL_CONCURRENCY in shouldImportConcurrencyByDefault where we make the decision?
There was a problem hiding this comment.
I don't think it would be easier, and adjusting it in LangOpts makes the default match the build setup. Otherwise, I don't have a strong opinion about this. If people want to debate this in a subsequent pull request, that seems fine. I just want to unbreak minimum dependency builds.
For various reasons, it can be useful/interesting to create builds of Swift that minimize dependencies. Let's try to keep that working as long as we can.
|
@swift-ci please smoke test |
|
If concurrency is not essential to the test, then it's better to disable it to improve testing coverage on configurations with concurrency disabled. |
For various reasons, it can be useful/interesting to create builds of Swift that minimize dependencies. Let's try to keep that working as long as we can.