[SR-13483][Sema] Make sure to record the correct remove args fix when repairing a tuple destructure attempt #36883
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LucianoPAlmeida
force-pushed
the
SR-13483-closure-args
branch
2 times, most recently
from
0f525d5 to
9f00c21
Compare
…smatch involving tuple destructuring
LucianoPAlmeida
force-pushed
the
SR-13483-closure-args
branch
from
9f00c21 to
c1f43c8
Compare
xedin
reviewed
Apr 14, 2021
xedin
reviewed
Apr 14, 2021
xedin
approved these changes
Apr 15, 2021
LucianoPAlmeida
force-pushed
the
SR-13483-closure-args
branch
from
e890177 to
f40b9b6
Compare
|
@swift-ci Please smoke test |
|
@swift-ci Please smoke test Linux Platform |
|
Thanks @xedin! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When handling special cases for SE-0110 in repair failures, we were always recording the adding missing fix. But in case it is attempting a destructuring, it may happen that the problem is extra argurments on the closure.
So this just detect and record the remove args fix.
Resolves SR-13483.