Skip to content

Try an experiment #36886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 7 commits into from
Closed

Try an experiment #36886

wants to merge 7 commits into from

Conversation

Catfish-Man
Copy link
Contributor

No description provided.

@Catfish-Man
Copy link
Contributor Author

@swift-ci please benchmark

@swift-ci
Copy link
Contributor

Performance: -O

Regression OLD NEW DELTA RATIO
CStringShortAscii 1500 2530 +68.7% 0.59x
RangeReplaceableCollectionPlusDefault 772 1140 +47.7% 0.68x
CStringLongNonAscii 266 348 +30.8% 0.76x
CStringLongAscii 259 305 +17.8% 0.85x (?)
LineSink.scalars.alpha 76 88 +15.8% 0.86x
IndexPath.Subscript.Range.Mutation 224 254 +13.4% 0.88x (?)
ArrayPlusEqualSingleElementCollection 799 893 +11.8% 0.89x (?)
CharacterLiteralsLarge 97 108 +11.3% 0.90x (?)
StringEnumRawValueInitialization 560 620 +10.7% 0.90x (?)
ArrayPlusEqualFiveElementCollection 3367 3700 +9.9% 0.91x (?)
DictionaryKeysContainsCocoa 26 28 +7.7% 0.93x (?)
 
Improvement OLD NEW DELTA RATIO
ArrayInClass 1540 370 -76.0% 4.16x
DistinctClassFieldAccesses 320 80 -75.0% 4.00x
UTF8Decode_InitFromCustom_noncontiguous_ascii 997 454 -54.5% 2.20x
LineSink.bytes.complex 194 104 -46.4% 1.87x
LineSink.scalars.complex 194 104 -46.4% 1.87x
UTF8Decode_InitFromCustom_noncontiguous 401 237 -40.9% 1.69x
Hanoi 3430 2040 -40.5% 1.68x
HashTest 1590 1200 -24.5% 1.32x
FlattenListFlatMap 3927 3106 -20.9% 1.26x (?)
MapReduceShortString 18 15 -16.7% 1.20x (?)
RemoveWhereMoveInts 16 14 -12.5% 1.14x (?)
MapReduceClassShort2 178 156 -12.4% 1.14x (?)
LineSink.bytes.alpha 61 54 -11.5% 1.13x (?)
PrimsSplit 870 775 -10.9% 1.12x (?)
UTF8Decode_InitFromData_ascii 279 250 -10.4% 1.12x (?)
Prims 875 785 -10.3% 1.11x (?)
Prims.NonStrongRef.Unmanaged.Closure 168 151 -10.1% 1.11x (?)
PrefixWhileAnySeqCRangeIter 205 185 -9.8% 1.11x (?)
MapReduceAnyCollectionShort 1860 1680 -9.7% 1.11x (?)
Prims.NonStrongRef.Unmanaged 167 151 -9.6% 1.11x (?)
UTF8Decode_InitDecoding_ascii 294 266 -9.5% 1.11x (?)
PrefixWhileAnySeqCntRange 205 186 -9.3% 1.10x (?)
MapReduceShort 2060 1880 -8.7% 1.10x (?)
FilterEvenUsingReduce 1060 970 -8.5% 1.09x (?)
CSVParsingAltIndices2 792 726 -8.3% 1.09x (?)
UTF8Decode_InitFromCustom_contiguous_ascii 283 260 -8.1% 1.09x (?)
ArrayPlusEqualThreeElements 1520 1400 -7.9% 1.09x (?)
DataSetCountSmall 154 142 -7.8% 1.08x (?)
COWArrayGuaranteedParameterOverhead 3250 3000 -7.7% 1.08x (?)
Prims.NonStrongRef.UnmanagedUGR.Closure 169 156 -7.7% 1.08x (?)
Prims.NonStrongRef.UnownedUnsafe.Closure 209 193 -7.7% 1.08x (?)
Prims.NonStrongRef.UnownedUnsafe 208 194 -6.7% 1.07x (?)
Prims.NonStrongRef.UnmanagedUGR 167 156 -6.6% 1.07x (?)

Code size: -O

Improvement OLD NEW DELTA RATIO
RemoveWhere.o 16155 14451 -10.5% 1.12x
ArrayInClass.o 4163 3764 -9.6% 1.11x
SortArrayInClass.o 2716 2503 -7.8% 1.09x
Array2D.o 2949 2770 -6.1% 1.06x
ArraySetElement.o 1308 1229 -6.0% 1.06x
COWArrayGuaranteedParameterOverhead.o 1383 1304 -5.7% 1.06x
Sim2DArray.o 1388 1309 -5.7% 1.06x
ObserverClosure.o 2446 2310 -5.6% 1.06x
ObserverPartiallyAppliedMethod.o 2493 2357 -5.5% 1.06x
RandomShuffle.o 3453 3269 -5.3% 1.06x
RangeAssignment.o 3401 3227 -5.1% 1.05x
ObserverForwarderStruct.o 3052 2906 -4.8% 1.05x
Hanoi.o 3209 3061 -4.6% 1.05x
MonteCarloE.o 2889 2764 -4.3% 1.05x
FlattenList.o 3978 3810 -4.2% 1.04x
Join.o 1593 1527 -4.1% 1.04x
LazyFilter.o 7944 7632 -3.9% 1.04x
Memset.o 2227 2148 -3.5% 1.04x
ArraySubscript.o 2414 2332 -3.4% 1.04x
DiffingMyers.o 6845 6629 -3.2% 1.03x
RomanNumbers.o 6886 6676 -3.0% 1.03x
PopFrontGeneric.o 2694 2612 -3.0% 1.03x
StackPromo.o 2265 2199 -2.9% 1.03x
AngryPhonebook.o 8951 8698 -2.8% 1.03x
BucketSort.o 8799 8551 -2.8% 1.03x
Breadcrumbs.o 44235 43043 -2.7% 1.03x
ReversedCollections.o 8662 8430 -2.7% 1.03x
SortIntPyramids.o 9136 8910 -2.5% 1.03x
ClassArrayGetter.o 3352 3270 -2.4% 1.03x
NopDeinit.o 3607 3519 -2.4% 1.03x
RangeOverlaps.o 6658 6500 -2.4% 1.02x
ChainedFilterMap.o 3189 3117 -2.3% 1.02x
Combos.o 6038 5902 -2.3% 1.02x
StringRemoveDupes.o 5807 5677 -2.2% 1.02x
RangeReplaceableCollectionPlusDefault.o 5820 5690 -2.2% 1.02x
ReduceInto.o 13819 13513 -2.2% 1.02x
StringSplitting.o 36022 35246 -2.2% 1.02x
PopFront.o 3762 3683 -2.1% 1.02x
ObserverUnappliedMethod.o 5209 5105 -2.0% 1.02x
SortLettersInPlace.o 8290 8128 -2.0% 1.02x
CString.o 6367 6247 -1.9% 1.02x
RC4.o 3521 3455 -1.9% 1.02x
Phonebook.o 10031 9847 -1.8% 1.02x
Walsh.o 4804 4716 -1.8% 1.02x
ProtocolConformance.o 3983 3911 -1.8% 1.02x
RGBHistogram.o 21474 21130 -1.6% 1.02x
Hash.o 22007 21663 -1.6% 1.02x
DictionaryGroup.o 11799 11615 -1.6% 1.02x
BinaryFloatingPointProperties.o 5104 5025 -1.5% 1.02x
Queue.o 12151 11967 -1.5% 1.02x
PrimsNonStrongRef.o 133408 131552 -1.4% 1.01x
StaticArray.o 12684 12508 -1.4% 1.01x
IndexPathTest.o 8680 8560 -1.4% 1.01x
RandomTree.o 12271 12103 -1.4% 1.01x
StrToInt.o 4843 4777 -1.4% 1.01x
Diffing.o 7899 7795 -1.3% 1.01x
StringEdits.o 10005 9875 -1.3% 1.01x
FindStringNaive.o 8491 8387 -1.2% 1.01x
MapReduce.o 27417 27094 -1.2% 1.01x
WordCount.o 37537 37129 -1.1% 1.01x
ArrayAppend.o 24793 24529 -1.1% 1.01x
DictOfArraysToArrayOfDicts.o 22873 22641 -1.0% 1.01x
DropLast.o 21310 21094 -1.0% 1.01x

Performance: -Osize

Regression OLD NEW DELTA RATIO
CStringShortAscii 1500 2560 +70.7% 0.59x
MapReduceLazyCollectionShort 64 85 +32.8% 0.75x
CStringLongNonAscii 272 349 +28.3% 0.78x (?)
CStringLongAscii 261 304 +16.5% 0.86x (?)
IndexPath.Subscript.Range.Mutation 226 258 +14.2% 0.88x (?)
LineSink.scalars.alpha 82 93 +13.4% 0.88x
PrefixWhileAnyCollectionLazy 176 194 +10.2% 0.91x
SubstringFromLongString 10 11 +10.0% 0.91x (?)
ArrayPlusEqualFiveElementCollection 3404 3700 +8.7% 0.92x (?)
 
Improvement OLD NEW DELTA RATIO
ArrayInClass 1570 340 -78.3% 4.62x
DistinctClassFieldAccesses 317 80 -74.8% 3.96x
LineSink.bytes.complex 199 102 -48.7% 1.95x
LineSink.scalars.complex 199 102 -48.7% 1.95x
Hanoi 3720 2290 -38.4% 1.62x
HashTest 1660 1200 -27.7% 1.38x
FlattenListFlatMap 3999 3130 -21.7% 1.28x (?)
MapReduceShortString 19 15 -21.1% 1.27x (?)
StringFromLongWholeSubstring 5 4 -20.0% 1.25x
MapReduceAnyCollectionShort 2030 1720 -15.3% 1.18x (?)
TypeName 1177 1006 -14.5% 1.17x (?)
ArrayPlusEqualThreeElements 1800 1550 -13.9% 1.16x (?)
Prims 1085 945 -12.9% 1.15x
COWArrayGuaranteedParameterOverhead 3500 3050 -12.9% 1.15x (?)
PrimsSplit 1075 940 -12.6% 1.14x (?)
MapReduceShort 2130 1870 -12.2% 1.14x (?)
FilterEvenUsingReduce 1110 980 -11.7% 1.13x (?)
LineSink.bytes.alpha 61 55 -9.8% 1.11x (?)
UTF8Decode_InitFromData_ascii 286 258 -9.8% 1.11x (?)
UTF8Decode_InitFromCustom_contiguous_ascii_as_ascii 424 383 -9.7% 1.11x (?)
PrefixWhileAnySeqCntRange 208 188 -9.6% 1.11x
CSVParsingAltIndices2 924 836 -9.5% 1.11x (?)
PrefixWhileAnySeqCRangeIter 207 188 -9.2% 1.10x
UTF8Decode_InitDecoding_ascii 284 258 -9.2% 1.10x (?)
UTF8Decode_InitFromCustom_contiguous_ascii 294 268 -8.8% 1.10x (?)
DropFirstAnySeqCRangeIter 199 182 -8.5% 1.09x (?)
DropFirstAnySeqCntRange 199 182 -8.5% 1.09x (?)
DropLastCountableRange 12 11 -8.3% 1.09x
SuffixCountableRangeLazy 12 11 -8.3% 1.09x (?)
UTF8Decode_InitFromBytes_ascii 322 296 -8.1% 1.09x (?)
DropLastAnySeqCRangeIter 794 733 -7.7% 1.08x (?)
NibbleSort 3170 2930 -7.6% 1.08x (?)
DataToStringSmall 2700 2500 -7.4% 1.08x (?)
Set.isSubset.Empty.Int 167 155 -7.2% 1.08x
ArrayAppendAscii 3332 3094 -7.1% 1.08x (?)
ArrayAppendUTF16 3332 3094 -7.1% 1.08x (?)
ArrayAppendLatin1 3434 3196 -6.9% 1.07x (?)
Set.isStrictSubset.Int.Empty 88 82 -6.8% 1.07x (?)
Set.isStrictSubset.Empty.Int 180 168 -6.7% 1.07x (?)

Code size: -Osize

Improvement OLD NEW DELTA RATIO
ChainedFilterMap.o 3059 2746 -10.2% 1.11x
ArrayInClass.o 4375 3972 -9.2% 1.10x
RandomShuffle.o 3473 3154 -9.2% 1.10x
SortArrayInClass.o 2809 2562 -8.8% 1.10x
Array2D.o 2666 2495 -6.4% 1.07x
StringSplitting.o 35264 33187 -5.9% 1.06x
ArraySetElement.o 1291 1221 -5.4% 1.06x
Sim2DArray.o 1343 1273 -5.2% 1.05x
COWArrayGuaranteedParameterOverhead.o 1362 1292 -5.1% 1.05x
ObserverForwarderStruct.o 3076 2930 -4.7% 1.05x
LazyFilter.o 7280 6944 -4.6% 1.05x
Join.o 1598 1528 -4.4% 1.05x
RangeAssignment.o 3256 3115 -4.3% 1.05x
MonteCarloE.o 2857 2738 -4.2% 1.04x
Hash.o 18511 17768 -4.0% 1.04x
Hanoi.o 3083 2960 -4.0% 1.04x
ObserverClosure.o 2644 2542 -3.9% 1.04x
ObserverPartiallyAppliedMethod.o 2693 2591 -3.8% 1.04x
DiffingMyers.o 6750 6501 -3.7% 1.04x
FlattenList.o 3824 3683 -3.7% 1.04x
Memset.o 1930 1860 -3.6% 1.04x
RC4.o 3085 2977 -3.5% 1.04x
RangeReplaceableCollectionPlusDefault.o 5542 5356 -3.4% 1.03x
StackPromo.o 2104 2034 -3.3% 1.03x
RomanNumbers.o 5241 5069 -3.3% 1.03x
StrToInt.o 4553 4414 -3.1% 1.03x
ArraySubscript.o 2440 2370 -2.9% 1.03x
ObserverUnappliedMethod.o 5188 5042 -2.8% 1.03x
StringRemoveDupes.o 3746 3645 -2.7% 1.03x
Prims.o 23043 22423 -2.7% 1.03x
PrimsSplit.o 23095 22475 -2.7% 1.03x
PopFrontGeneric.o 2742 2672 -2.6% 1.03x
BucketSort.o 8398 8184 -2.5% 1.03x
RangeOverlaps.o 5633 5492 -2.5% 1.03x
ClassArrayGetter.o 3087 3012 -2.4% 1.02x
ReversedCollections.o 7510 7338 -2.3% 1.02x
RandomTree.o 11361 11129 -2.0% 1.02x
Combos.o 6040 5917 -2.0% 1.02x
PopFront.o 3460 3390 -2.0% 1.02x
NibbleSort.o 14183 13912 -1.9% 1.02x
ProtocolConformance.o 3742 3672 -1.9% 1.02x
NopDeinit.o 4288 4213 -1.7% 1.02x
CString.o 5878 5777 -1.7% 1.02x
SortIntPyramids.o 8979 8825 -1.7% 1.02x
PrefixWhile.o 13807 13574 -1.7% 1.02x
Walsh.o 4240 4170 -1.7% 1.02x
SortLettersInPlace.o 7687 7566 -1.6% 1.02x
Phonebook.o 9177 9034 -1.6% 1.02x
FindStringNaive.o 8020 7897 -1.5% 1.02x
ReduceInto.o 8218 8093 -1.5% 1.02x
StaticArray.o 11947 11769 -1.5% 1.02x
DictionaryGroup.o 10363 10216 -1.4% 1.01x
AngryPhonebook.o 8227 8112 -1.4% 1.01x
BinaryFloatingPointProperties.o 5114 5044 -1.4% 1.01x
ArrayAppend.o 22309 22023 -1.3% 1.01x
DictionaryOfAnyHashableStrings.o 5479 5409 -1.3% 1.01x
Queue.o 12024 11875 -1.2% 1.01x
StringEdits.o 10048 9925 -1.2% 1.01x
RGBHistogram.o 19586 19355 -1.2% 1.01x
ArrayOfGenericRef.o 8276 8179 -1.2% 1.01x
PrimsNonStrongRef.o 84345 83371 -1.2% 1.01x
ArrayOfRef.o 8528 8431 -1.1% 1.01x
Prefix.o 14936 14774 -1.1% 1.01x
DictionaryCompactMapValues.o 12951 12812 -1.1% 1.01x
LuhnAlgoEager.o 13079 12939 -1.1% 1.01x
LuhnAlgoLazy.o 13079 12939 -1.1% 1.01x
DropWhile.o 15400 15238 -1.1% 1.01x
DropFirst.o 15451 15289 -1.0% 1.01x

Performance: -Onone

Regression OLD NEW DELTA RATIO
CStringShortAscii 4030 5180 +28.5% 0.78x (?)
CStringLongNonAscii 350 440 +25.7% 0.80x (?)
CStringLongAscii 365 430 +17.8% 0.85x (?)
LineSink.scalars.alpha 308 348 +13.0% 0.89x (?)
IndexPath.Subscript.Range.Mutation 241 271 +12.4% 0.89x (?)
DataAppendDataMediumToSmall 5160 5680 +10.1% 0.91x (?)
 
Improvement OLD NEW DELTA RATIO
UTF8Decode_InitFromData_ascii 295 268 -9.2% 1.10x (?)
StringInterpolationSmall 4430 4090 -7.7% 1.08x (?)
UTF8Decode_InitDecoding_ascii 341 315 -7.6% 1.08x (?)
UTF8Decode_InitDecoding_ascii_as_ascii 325 301 -7.4% 1.08x (?)
UTF8Decode_InitFromBytes_ascii 329 307 -6.7% 1.07x (?)

Code size: -swiftlibs

How to read the data The tables contain differences in performance which are larger than 8% and differences in code size which are larger than 1%.

If you see any unexpected regressions, you should consider fixing the
regressions before you merge the PR.

Noise: Sometimes the performance results (not code size!) contain false
alarms. Unexpected regressions which are marked with '(?)' are probably noise.
If you see regressions which you cannot explain you can try to run the
benchmarks again. If regressions still show up, please consult with the
performance team (@eeckstein).

Hardware Overview 
  Model Name: Mac Pro
  Model Identifier: MacPro6,1
  Processor Name: 12-Core Intel Xeon E5
  Processor Speed: 2.7 GHz
  Number of Processors: 1
  Total Number of Cores: 12
  L2 Cache (per Core): 256 KB
  L3 Cache: 30 MB
  Memory: 64 GB

@airspeedswift
Copy link
Member

Sooo the fast path is slower?

@Catfish-Man
Copy link
Contributor Author

@swift-ci please benchmark

@Catfish-Man
Copy link
Contributor Author

@swift-ci please benchmark

@Catfish-Man
Copy link
Contributor Author

@swift-ci please benchmark

@swift-ci
Copy link
Contributor

Build failed before running benchmark.

@Catfish-Man
Copy link
Contributor Author

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 189b944

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 189b944

@Catfish-Man
Copy link
Contributor Author

Reminder for myself next time: you're waiting on Michael to figure out the compiler bug it's hitting

/Users/david/swift-external/build/Ninja-ReleaseAssert+stdlib-Release/swift-macosx-x86_64/stdlib/public/core/8/Tuple.swift

  1. While evaluating request IRGenRequest(IR Generation for module Swift)
  2. While evaluating request ExecuteSILPipelineRequest(Run pipelines { IRGen Preparation } on SIL for Swift)
  3. While running pass [Parse] Consolidate body parsing for Func/Constructor/Destructor decls #19018 SILFunctionTransform "StackSizeLimitTransform" on SILFunction "@$ss6SIMD32V16debugDescriptionSSvg".
    for getter for debugDescription (at /Users/david/swift-external/build/Ninja-ReleaseAssert+stdlib-Release/swift-macosx-x86_64/stdlib/public/core/8/SIMDVectorTypes.swift:1022:14)
    Stack dump without symbol names (ensure you have llvm-symbolizer in your PATH or set the environment var LLVM_SYMBOLIZER_PATH to point to it):
    0 swift-frontend 0x0000000107edf9d7 llvm::sys::PrintStackTrace(llvm::raw_ostream&, int) + 39
    1 swift-frontend 0x0000000107ede8e8 llvm::sys::RunSignalHandlers() + 248
    2 swift-frontend 0x0000000107ee0236 SignalHandler(int) + 278
    3 libsystem_platform.dylib 0x00007ff803dbd06d _sigtramp + 29
    4 libsystem_platform.dylib 0x0000000000000001 _sigtramp + 18446603370516197297
    5 libsystem_c.dylib 0x00007ff803cf9d10 abort + 123
    6 libsystem_c.dylib 0x00007ff803cf90be err + 0
    7 swift-frontend 0x0000000107f3aba3 swift::SILBuilder::createAllocBox(swift::SILLocation, swift::CanTypeWrapperswift::SILBoxType, llvm::Optionalswift::SILDebugVariable, bool) (.cold.1) + 35
    8 swift-frontend 0x00000001034da3f2 swift::SILBuilder::createAllocBox(swift::SILLocation, swift::CanTypeWrapperswift::SILBoxType, llvm::Optionalswift::SILDebugVariable, bool) + 386
    9 swift-frontend 0x000000010381daa3 swift::SILBuilder::createAllocBox(swift::SILLocation, swift::SILType, llvm::Optionalswift::SILDebugVariable, bool) + 227
    10 swift-frontend 0x000000010381d777 convertStackBoxToHeapBox(swift::AllocStackInst*, llvm::ilist_iterator<llvm::ilist_detail::node_options<swift::SILInstruction, true, false, void>, false, false>) + 183
    11 swift-frontend 0x000000010381ce38 (anonymous namespace)::StackSizeLimitTransform::run() + 248
    12 swift-frontend 0x0000000103c3d4ae swift::SILPassManager::runPassOnFunction(unsigned int, swift::SILFunction*) + 1822
    13 swift-frontend 0x0000000103c3e3da swift::SILPassManager::runFunctionPasses(unsigned int, unsigned int) + 1386
    14 swift-frontend 0x0000000103c3b218 swift::SILPassManager::executePassPipelinePlan(swift::SILPassPipelinePlan const&) + 72
    15 swift-frontend 0x0000000103c3b1b3 swift::ExecuteSILPipelineRequest::evaluate(swift::Evaluator&, swift::SILPipelineExecutionDescriptor) const + 51
    16 swift-frontend 0x0000000103c5bfed swift::SimpleRequest<swift::ExecuteSILPipelineRequest, std::__1::tuple<> (swift::SILPipelineExecutionDescriptor), (swift::RequestFlags)1>::evaluateRequest(swift::ExecuteSILPipelineRequest const&, swift::Evaluator&) + 29
    17 swift-frontend 0x0000000103c47481 llvm::Expectedswift::ExecuteSILPipelineRequest::OutputType swift::Evaluator::getResultUncachedswift::ExecuteSILPipelineRequest(swift::ExecuteSILPipelineRequest const&) + 241
    18 swift-frontend 0x0000000103c3b444 swift::executePassPipelinePlan(swift::SILModule*, swift::SILPassPipelinePlan const&, bool, swift::irgen::IRGenModule*) + 68
    19 swift-frontend 0x0000000103789191 swift::IRGenRequest::evaluate(swift::Evaluator&, swift::IRGenDescriptor) const + 2209
    20 swift-frontend 0x00000001037c2efc swift::GeneratedModule swift::SimpleRequest<swift::IRGenRequest, swift::GeneratedModule (swift::IRGenDescriptor), (swift::RequestFlags)9>::callDerived<0ul>(swift::Evaluator&, std::__1::integer_sequence<unsigned long, 0ul>) const + 204
    21 swift-frontend 0x00000001037c2dee swift::SimpleRequest<swift::IRGenRequest, swift::GeneratedModule (swift::IRGenDescriptor), (swift::RequestFlags)9>::evaluateRequest(swift::IRGenRequest const&, swift::Evaluator&) + 14
    22 swift-frontend 0x00000001037941b5 llvm::Expectedswift::IRGenRequest::OutputType swift::Evaluator::getResultUncachedswift::IRGenRequest(swift::IRGenRequest const&) + 389
    23 swift-frontend 0x000000010378a2d9 swift::performIRGeneration(swift::ModuleDecl*, swift::IRGenOptions const&, swift::TBDGenOptions const&, std::__1::unique_ptr<swift::SILModule, std::__1::default_deleteswift::SILModule >, llvm::StringRef, swift::PrimarySpecificPaths const&, llvm::ArrayRef<std::__1::basic_string<char, std::__1::char_traits, std::__1::allocator > >, llvm::GlobalVariable**) + 649
    24 swift-frontend 0x0000000103333919 performCompileStepsPostSILGen(swift::CompilerInstance&, std::__1::unique_ptr<swift::SILModule, std::__1::default_deleteswift::SILModule >, llvm::PointerUnion<swift::ModuleDecl*, swift::SourceFile*>, swift::PrimarySpecificPaths const&, int&, swift::FrontendObserver*) + 1705
    25 swift-frontend 0x000000010333302d performCompileStepsPostSema(swift::CompilerInstance&, int&, swift::FrontendObserver*) + 685
    26 swift-frontend 0x000000010332757d swift::performFrontend(llvm::ArrayRef<char const*>, char const*, void*, swift::FrontendObserver*) + 4637
    27 swift-frontend 0x00000001032d1dd3 swift::mainEntry(int, char const**) + 499
    28 dyld 0x00000001146d24d5 start + 421
    29 dyld 000000000000000000 start + 18446744069071887568
    30 swift-frontend 0x00000001032af000 __dso_handle + 0
    [26/712][ 3%][142.157s] Generating /Users/david/swift-external/b.../lib/swift/macosx/Swift.swiftmodule/arm64-apple-macos.swiftmodule

tbkka
tbkka reviewed Aug 23, 2021
View reviewed changes
include/swift/AST/Builtins.def
@@ -880,6 +880,11 @@ BUILTIN_MISC_OPERATION_WITH_SILGEN(BuildDefaultActorExecutorRef,
BUILTIN_MISC_OPERATION_WITH_SILGEN(BuildMainActorExecutorRef,
"buildMainActorExecutorRef", "n", Special)

/// isOnStack : (Builtin.NativeObject) -> Builtin.Int1
///
/// Returns true if the optimizer successfully moved this object from the stack onto the heap.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this comment backwards?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so but you'll have to ask @gottesmm since it's from his PR that I merged into this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbkka tbkka tbkka left review comments

@eeckstein eeckstein Awaiting requested review from eeckstein eeckstein will be requested when the pull request is marked ready for review eeckstein is a code owner

@jckarter jckarter Awaiting requested review from jckarter jckarter will be requested when the pull request is marked ready for review jckarter is a code owner

@rjmccall rjmccall Awaiting requested review from rjmccall rjmccall will be requested when the pull request is marked ready for review rjmccall is a code owner

@hborla hborla Awaiting requested review from hborla hborla will be requested when the pull request is marked ready for review hborla is a code owner

@slavapestov slavapestov Awaiting requested review from slavapestov slavapestov will be requested when the pull request is marked ready for review slavapestov is a code owner

@xedin xedin Awaiting requested review from xedin xedin will be requested when the pull request is marked ready for review xedin is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Catfish-Man @swift-ci @airspeedswift @tbkka