[Gardening] Do not store start/end line in SingleRawComment #36920
Conversation
|
@swift-ci please test |
|
Build failed |
|
Build failed |
|
Ah, sorry. I pulled this out of a larger change but messed it up - fixing now. |
bnbarham
force-pushed
the
cleanup-rawcomment
branch
from
cd8d76b to
854626b
Compare
|
@swift-ci please test |
| @@ -61,71 +61,53 @@ SingleRawComment::SingleRawComment(CharSourceRange Range, | |||
| const SourceManager &SourceMgr) | |||
| : Range(Range), RawText(SourceMgr.extractText(Range)), | |||
There was a problem hiding this comment.
RawText and ColumnIndent are the only two fields on RawComment that are actually always valid. Range is only set when it isn't a deserialized RawComment. Ideally we'd remove Range from here as well, but it's used in a fair few places... This change is a middle ground where just StartLine/EndLine are removed.
|
Build failed |
|
Build failed |
bnbarham
force-pushed
the
cleanup-rawcomment
branch
from
854626b to
502ccc7
Compare
|
@swift-ci please test |
The start and end lines were only used while constructing the comments, so move the line tracking into that method instead of storing it in each comment.
bnbarham
force-pushed
the
cleanup-rawcomment
branch
from
502ccc7 to
52de30c
Compare
|
@swift-ci please smoke test |
|
@swift-ci please smoke test macOS platform |
The start and end lines were only used while constructing the comments,
so move the line tracking into that method instead of storing it in each
comment.