[Sema] Fix stale reference passed to PlaceholderType::get #36948
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @xedin |
xedin
approved these changes
Apr 17, 2021
|
@swift-ci please smoke test |
|
@xedin Failure here looks unrelated, think this is good to merge? |
|
Let’s try one more time |
|
@swift-ci please smoke test macOS platform |
|
Looks like same failure occurred on #36949, seems unrelated to these changes. (Potentially related to swiftlang/llvm-project#2851?) |
|
I can’t merge until macOS passes because it’s a required check, only admins can merge that :/ |
|
Got it! No worries at all, please enjoy the weekend :) |
|
Thanks, you too! |
|
@swift-ci please smoke test macOS platform |
|
Looks like the problematic test has been disabled in swiftlang/llvm-project#2854 (thanks, @ktoso!) |
|
@swift-ci please smoke test macOS platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When parsing placeholder types (see #36740) there's an odd crash in
PlaceholderType::getthat only happens in release builds. It seems to be related to a stale captured reference to theASTContextmaking its way through type resolution, so this PR makes sure we theASTContextreference down the stack explicitly to avoid any strange capture behavior.