[AutoDiff] [AST] Handle null decl in 'printDifferentiableAttrArguments'. #36954
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
`DeclAttribute::print()` accepts null decls and has a null default argument. A segfault was triggered in SourceKitService because `printDifferentiableAttrArguments()` took a null decl and deferenced it. This patch makes `printDifferentiableAttrArguments()` handle null decls — if the decl is null, we do not print the differentiability parameters or the `where` clause. I have not added a unit test however because I haven't been able to reproduce it independently. This will be done later as this change is low-risk. Resolves rdar://76095289.
|
@swift-ci please test |
joshnewnham
approved these changes
Apr 18, 2021
dan-zheng
approved these changes
Apr 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DeclAttribute::print()accepts null decls and has a null default argument. A segfault was triggered in SourceKitService becauseprintDifferentiableAttrArgumentstook a null decl and deferenced it. This patch makesprintDifferentiableAttrArguments()handle null decls — if the decl is null, we do not print the differentiability parameters or thewhereclause.I have not added a unit test however because I haven't been able to reproduce it independently. This will be done later as this change is low-risk.
Resolves rdar://76095289.