[completion] Clarify and simplify not-recommended state #36961
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Combine IsNotRecommended with NotRecommendedReason and improve the names of the existing cases to more clearly identify the cases they apply to. Now all not-recommended completions are required to have a reason.
|
@swift-ci please smoke test |
rintaro
reviewed
Apr 19, 2021
include/swift/IDE/CodeCompletion.h
Outdated
| bool isNotRecommended() const { | ||
| return NotRecommended; | ||
| } | ||
| bool isNotRecommended() const { return NotRecommended != None; } |
There was a problem hiding this comment.
Please
Suggested change
| bool isNotRecommended() const { return NotRecommended != None; } | |
| bool isNotRecommended() const { return NotRecommended != NotRecommendedReason::None; } |
None sounds too generic for a symbol that can be referenced as a direct member of CodeCompletionResult (i.e. CodeCompletionResult::None). We probably should make NotRecommendedReason (and ExpectedTypeRelation, etc) a scoped enum.
There was a problem hiding this comment.
SGTM, I'll make it enum class NotRecommendedReason. I'll leave ExpectedTypeRelation for follow-up.
|
@swift-ci please smoke test |
rintaro
approved these changes
Apr 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Combine IsNotRecommended with NotRecommendedReason and improve the names
of the existing cases to more clearly identify the cases they apply to.
Now all not-recommended completions are required to have a reason.