Prevent arbitrary objects from conforming to RNG. #36969
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Me, sobbing: "Look, you can't just point at an empty struct and call it a RandomNumberGenerator." Swift 5.4, pointing at anything: "RNG."
stephentyrone
requested review from
airspeedswift,
lorentey,
timvermeulen and
Azoy
|
@swift-ci test |
|
Build failed |
Azoy
approved these changes
Apr 20, 2021
|
@swift-ci please test linux |
stephentyrone
added a commit
to stephentyrone/swift
that referenced
this pull request
Apr 21, 2021
Me, sobbing: "Look, you can't just point at an empty struct and call it a RandomNumberGenerator." Swift 5.4, pointing at anything: "RNG."
stephentyrone
added a commit
that referenced
this pull request
Apr 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Me, sobbing: "Look, you can't just point at an empty struct and call it a RandomNumberGenerator."
Swift 5.4, pointing at absolutely anything: "RNG."
This is technically a source-breaking change. However, any RNG that depended on this behavior to conform to the protocol was necessarily already broken; it could never have worked correctly. So we're simply moving the crash from runtime to compile time, making it easier for users to find and do something about it.
Fixes rdar://76660011