Disabling of most llvm tools when not testing swift #3697
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
gottesmm
force-pushed
the
disabling-of-most-llvm-tools-when-not-testing-swift
branch
from
9e16be0 to
dc070c8
Compare
|
@swift-ci Please smoke test |
|
@swift-ci Please smoke test linux platform |
|
@swift-ci Please smoke test OS X platform |
…he cmake variable that is being set to false. This is just a simple NFC cleanup commit.
…DE_TESTS via SOURCE_TREE_CINDLUES_TESTS. It is by default set to True and we turn it off via the variable LLVM_INCLUDE_TESTS now. This actually became a no-op since the build-script-impl triggered instance of LLVM_INCLUDE_TESTS is always put strictly after this instance of setting the cmake variable on the cmake line.
This matches cmake more closely and also matches the build-script-impl argument
for including llvm tests ("llvm-include-tests").
…M, disable all parts of LLVM that are not needed for compiling Swift.
…ools to its on function.
gottesmm
force-pushed
the
disabling-of-most-llvm-tools-when-not-testing-swift
branch
from
dc070c8 to
907f73d
Compare
|
@swift-ci Please test and merge |
| ) | ||
| done | ||
| echo "${OUTPUT[@]}" | ||
| } |
There was a problem hiding this comment.
SR-237 tracks migrating the code in build-script-impl to Python. Would it be possible to implement this function in Python instead?
There was a problem hiding this comment.
Sure. I will refactor in a subsequent commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this pull request?
Resolved bug number: (SR-)
Before merging this pull request to apple/swift repository:
Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
A smoke test on macOS does the following:
device standard libraries are not built.
version of these tests are not run.
A smoke test on Linux does the following:
tests are not run.
Validation Testing
Lint Testing
Note: Only members of the Apple organization can trigger swift-ci.