Cherry-Pick: [Concurrency] Don't propagate global actor-ness to deinit #36976
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Destructors can't be run on the main actor since they may be called from a asynchronous context. Because we are the only ones with a handle to the class, we can touch Main-Actor protected properties from anywhere safely. We can't touch static properties though since those will still be alive and accessible from outside of just this dying instance.
Updated the tests for non-global-actor protected deinit. We can't access main-actor synchronous functions, main-actor static properties, but can access non-static main-actor stored properties in the deinit.
|
@swift-ci please smoke test |
|
@swift-ci please test |
|
Failure looks like it's related to swiftlang/llvm-project#2856 not having landed in the 5.5 branch. |
DougGregor
approved these changes
Apr 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can't make destructors run on a global-actor. This patch disables propagating global-actorness to the destructor, blocking accessing to other functions and properties that are not on the local object instance.
Since the deinit is the only place with access to the instance of the object, so we can still safely access global-actor stored properties from the deinit.
Original PR: #36972
Fixes: rdar://76769567