[Linux] Use target-cpu for Linux in lto_autolink test #36999
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci smoke test |
|
It seems that %target-cpu is also not the right thing if one if building on Linux, but cross-compiling for Android. Both Android CI started failing after this change because they try to compile for aarch64-unknown-linux-gnu and armv7-unknown-linux-gnu. I don’t see how to make it work for all the platforms if you cannot ensure those swift stdlib targets are built, though. Why Darwin and Windows seems to work is really puzzling to me. |
|
😕 I'll XFAIL it for now. |
drexin
added a commit
that referenced
this pull request
May 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test fails on aarch64 when using x86_64 as target.