[ownership] Change CanonicalOSSALifetime to use an InstModCallback. #37003
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
atrick
approved these changes
Apr 22, 2021
gottesmm
force-pushed
the
pr-af8aa6d23b297a3ff4a3237f2dfe6fec12673023
branch
2 times, most recently
from
91660a4 to
953bfb2
Compare
|
@swift-ci test |
|
Build failed |
|
Build failed |
This enables passes to use this as a utility that properly composes with how the pass maintains its state. If an InstModCallback isn't passed in, we use the default InstModCallback which should be cheap (always succeeding check for nullptr + call inline default callback).
gottesmm
force-pushed
the
pr-af8aa6d23b297a3ff4a3237f2dfe6fec12673023
branch
from
953bfb2 to
c3c2b84
Compare
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables passes to use this as a utility that properly composes with how the
pass maintains its state. If an InstModCallback isn't passed in, we use the
default InstModCallback which should be cheap (always succeeding check for
nullptr + call inline default callback).
Should be NFC