Skip to content

[5.5][AST] Add method to create an implicit SwitchStmt #37009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ahoppen
Copy link
Member

@ahoppen ahoppen commented Apr 22, 2021

There are a number of occurances that create implicit Switchs by passing SourceLoc() for all location paramters. Refactor those occurrences out to a separate createImplicit method that automatically fills the locations with invalid source locations.

Cherry-picking #36973

There are a number of occurances that create implicit `Switch`s by passing `SourceLoc()` for all location paramters. Refactor those occurances out to a separate `createImplicit` method that automatically fills the locations with invalid source locations.
@ahoppen ahoppen requested a review from akyrtzi April 22, 2021 09:45
@ahoppen
Copy link
Member Author

ahoppen commented Apr 22, 2021

@swift-ci Please test

@ahoppen
Copy link
Member Author

ahoppen commented Apr 22, 2021

@swift-ci Please test Windows

@ahoppen ahoppen merged commit ecc8b4c into swiftlang:release/5.5 Apr 23, 2021
@ahoppen ahoppen deleted the pr-5.5/create-implicit-switch-stmt branch April 23, 2021 08:37
@ahoppen ahoppen added the r5.5 label Apr 26, 2021
@ahoppen ahoppen changed the title Cherry-Pick 5.5: [AST] Add method to create an implicit SwitchStmt [5.5][AST] Add method to create an implicit SwitchStmt Apr 26, 2021
@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - a88f17a

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - a88f17a

@AnthonyLatsis AnthonyLatsis added 🍒 release cherry pick Flag: Release branch cherry picks swift 5.5 labels Jan 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍒 release cherry pick Flag: Release branch cherry picks swift 5.5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants