[SILGen] Add SILDeclRef for main entry-point #37014
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
This will make it easier to store in a SILDeclRef.
This will be used to represent the entry-point for a main SourceFile.
Allow SILDeclRef to refer to the main program entry-point, which will either be for a main SourceFile, or a synthetic main such as an `@main` decl. Adjust the various SILDeclRef related functions to handle this new case, and change the emission to go through `emitFunctionDefinition`. This change will allow the entry-point for an `@main` decl (and eventually a main SourceFile) to be emitted on-demand from its symbol name.
Now that SILDeclRef can represent the main function, tweak TBDGen to refer to it.
hamishknight
force-pushed
the
entry-sign
branch
from
6be88eb to
9020c13
Compare
|
@swift-ci please test |
|
@swift-ci please test macOS |
CodaFi
approved these changes
Apr 27, 2021
There was a problem hiding this comment.
I like that we're using more of the built-in machinery in SILGen to emit this entrypoint. The changes here look good, in particular to TBDGen. I'm going to tag @eeckstein for a closer look at the SILDeclRef representation changes for which I have much less experience.
eeckstein
approved these changes
Apr 29, 2021
There was a problem hiding this comment.
LGTM, though it would be good if @slavapestov could also take a look.
slavapestov
approved these changes
May 18, 2021
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow SILDeclRef to refer to the main program entry-point, which will either be for a main SourceFile, or a synthetic main such as an
@maindecl. Adjust the various SILDeclRef related functions to handle this new case, and change the emission to go throughemitFunctionDefinition.This change will allow the entry-point for an
@maindecl (and eventually a main SourceFile) to be emitted on-demand from its symbol name.