Skip to content

[Diagnostics] Add tests to check diagnostic locations across modules #37032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 28, 2021
Merged

[Diagnostics] Add tests to check diagnostic locations across modules #37032

merged 1 commit into from
Apr 28, 2021

Conversation

bnbarham
Copy link
Contributor

NFC: There's some #sourceLocation tests for pretty-printed diagnostics, but no basic one. Added a simple loc-directive-diagnostics.swift for that.

multi-module-diagnostics.swift checks both the interaction with .swiftsourceinfo and #sourceLocation.

@bnbarham bnbarham requested a review from benlangmuir April 23, 2021 06:02
@bnbarham
Copy link
Contributor Author

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - e610c2601015f36807d20a95eda05ec7171963b7

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - e610c2601015f36807d20a95eda05ec7171963b7

@bnbarham
Copy link
Contributor Author

These depend on #37029 (forgot I had the lit lines commented out locally). They also have a bunch of FIXMEs, I could add to #36942, but it's already quite large...

@bnbarham bnbarham requested a review from rintaro April 23, 2021 22:31
@bnbarham
Copy link
Contributor Author

@swift-ci please test

@bnbarham
Copy link
Contributor Author

Windows backslashes strike again

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - df96b6ad77d063cc1e58a1bd91d7efb771292326

@bnbarham
Copy link
Contributor Author

CI workspaces can have @ in them, glad the tests happened to run in such a workspace!

@bnbarham
Copy link
Contributor Author

@swift-ci please test

@bnbarham
Copy link
Contributor Author

Tests passes, but noticed that I had a copy paste error in loc-directive-diagnostics.swift (had extra args in the frontend invocation). Will just run a smoketest now.

@swift-ci please smoke test

@bnbarham
Copy link
Contributor Author

Windows test is an out of space, passed before removing the args from loc-directive-diagnostics.swift so I'm just going to merge.

@bnbarham bnbarham merged commit 02b5be7 into swiftlang:main Apr 28, 2021
@bnbarham bnbarham deleted the loc-tests branch April 28, 2021 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rintaro rintaro rintaro approved these changes

@benlangmuir benlangmuir benlangmuir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bnbarham @swift-ci @rintaro @benlangmuir