Skip to content

[Sema] Do not attempt warn extraneous checked cast for placeholder types #37057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 25, 2021
Merged

[Sema] Do not attempt warn extraneous checked cast for placeholder types #37057

merged 1 commit into from
Apr 25, 2021

Conversation

LucianoPAlmeida
Copy link
Contributor

As mentioned here those fixes shouldn't be recorded for placeholder types.

@LucianoPAlmeida LucianoPAlmeida requested a review from xedin April 25, 2021 02:53
@LucianoPAlmeida
Copy link
Contributor Author

@swift-ci Please smoke test

xedin
xedin approved these changes Apr 25, 2021
View reviewed changes
Copy link
Contributor

@xedin xedin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@LucianoPAlmeida LucianoPAlmeida merged commit c15dde4 into swiftlang:main Apr 25, 2021
@LucianoPAlmeida LucianoPAlmeida deleted the placeholder-checkedcast-warn branch April 25, 2021 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xedin xedin xedin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LucianoPAlmeida @xedin