[5.5][Diagnostics] Avoid relying on solution for contextual purpose information #37066
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pose Having purpose attached to the contextual type element makes it much easier to diagnose contextual mismatches without involving constraint system state. (cherry picked from commit 51ff12d)
|
@swift-ci please test |
|
Build failed |
`ContextualFailure` is the main beneficiary of additional information associated with `ContextualType` element because it no longer has to query solution for "purpose" of the contextual information. Resolves: rdar://68795727 (cherry picked from commit 71372bc)
xedin
force-pushed
the
rdar-68795727-5.5
branch
from
06ea450 to
458fae7
Compare
|
@swift-ci please test |
hborla
approved these changes
Apr 27, 2021
AnthonyLatsis
added
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ContextualTypeelement to carry its purposeBoth of these changes mean that diagnostics no longer need to
query a solution for contextual "purpose" associated with a
particular location, which benefits
ContextualFailureand allof its subtypes.
Resolves: rdar://68795727