[Refactoring] Support refactoring to async if callback is @convention(block)
#37071
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
bnbarham
approved these changes
Apr 27, 2021
| // BLOCK-CONVENTION: func blockConvention() async { } | ||
|
|
||
| // RUN: %refactor -add-async-alternative -dump-text -source-filename %s -pos=%(line+1):1 | %FileCheck -check-prefix C-CONVENTION %s | ||
| func cConvention(completion: @convention(block) () -> Void) { } |
There was a problem hiding this comment.
Is this meant to be @convention(c)?
There was a problem hiding this comment.
Indeed, that was what I was trying to test.
…n(block)` We already have special logic to extrac the closure for closures with capture lists, add the same kind of logic for closures that are marked `@convention(block)` etc. Resolves rdar://75301524 [SR-14328]
ahoppen
force-pushed
the
pr/block-convention-to-async
branch
from
3615a31 to
f17fe86
Compare
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already have special logic to extract the closure for closures with capture lists. Add the same kind of logic for closures that are marked
@convention(block)etc.Resolves rdar://75301524 [SR-14328]