Skip to content

[Concurrency] Perform userInitiated adjustment after determining priority #37072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 27, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions stdlib/public/Concurrency/Actor.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -264,12 +264,12 @@ static bool isExecutingOnMainThread() {
}

JobPriority swift::swift_task_getCurrentThreadPriority() {
if (isExecutingOnMainThread())
return JobPriority::UserInitiated;

#if defined(__APPLE__)
return static_cast<JobPriority>(qos_class_self());
#else
if (isExecutingOnMainThread())
return JobPriority::UserInitiated;

return JobPriority::Unspecified;
#endif
}
Expand Down
4 changes: 4 additions & 0 deletions stdlib/public/Concurrency/Task.swift
Original file line number Diff line number Diff line change
Expand Up @@ -473,6 +473,10 @@ public func async(
actualPriority = priority
}

let adjustedPriority = actualPriority == .userInteractive
? .userInitiated
: actualPriority

// Set up the job flags for a new task.
var flags = Task.JobFlags()
flags.kind = .task
Expand Down