[NFC][AutoDiff] Pass AutoDiffConfig by const ref. #37074
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
CertifiedRice
approved these changes
Apr 27, 2021
|
Build failed |
|
@swift-ci Please smoke test linux |
|
@swift-ci Please test |
|
Build failed |
|
@swift-ci Please test linux |
|
@swift-ci Please smoke test linux |
|
Build failed |
|
@swift-ci Please clean test linux |
rxwei
approved these changes
Apr 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AutoDiffConfig is a trivial structure but its size is greater than two registers. It makes an object most likely to be placed on a stack while passing it by value. Here is a small example: https://godbolt.org/z/onMbz1vnW
The change is NFC, making all functions that expect AutoDiffConfig as an argument to be passes by constant reference.