[Concurrency] Reduce overhead of Task.yield and Task.sleep #37090
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci smoke test |
drexin
force-pushed
the
wip-improve-yield-sleep
branch
from
712d674 to
6291698
Compare
|
@swift-ci smoke test |
|
@swift-ci smoke test windows |
|
@swift-ci smoke test macos |
|
@swift-ci smoke test windows |
drexin
force-pushed
the
wip-improve-yield-sleep
branch
from
6291698 to
8212492
Compare
|
@swift-ci smoke test |
drexin
force-pushed
the
wip-improve-yield-sleep
branch
from
8212492 to
3f9a58e
Compare
|
@swift-ci smoke test |
|
@swift-ci smoke test macos |
1 similar comment
|
@swift-ci smoke test macos |
Instead of creating a new task, we create a simple job that wraps a Builtin.RawUnsafeContinuation and resumes the continuation when it is executed. The job instance is allocated on the task local allocator, meaning we don't malloc anything.
drexin
force-pushed
the
wip-improve-yield-sleep
branch
from
3f9a58e to
ed00146
Compare
|
@swift-ci smoke test |
|
@swift-ci smoke test windows |
|
@swift-ci smoke test macos |
ktoso
reviewed
May 8, 2021
ktoso
reviewed
May 8, 2021
| continuation); | ||
|
|
||
| return job; | ||
| } |
ktoso
reviewed
May 8, 2021
| return await Builtin.withUnsafeContinuation { (continuation: Builtin.RawUnsafeContinuation) -> Void in | ||
| let job = _taskCreateNullaryContinuationJob(priority: priority.rawValue, continuation: continuation) | ||
| _enqueueJobGlobal(job) | ||
| } |
Co-authored-by: Konrad `ktoso` Malawski <[email protected]>
|
@swift-ci smoke test |
|
@swift-ci smoke test windows |
1 similar comment
|
@swift-ci smoke test windows |
|
Windows failure is unrelated. |
drexin
added a commit
to drexin/swift
that referenced
this pull request
May 10, 2021
…#37090) * [Concurrency] Reduce overhead of Task.yield and Task.sleep Instead of creating a new task, we create a simple job that wraps a Builtin.RawUnsafeContinuation and resumes the continuation when it is executed. The job instance is allocated on the task local allocator, meaning we don't malloc anything. * Update stdlib/public/Concurrency/Task.swift Co-authored-by: Konrad `ktoso` Malawski <[email protected]> Co-authored-by: Konrad `ktoso` Malawski <[email protected]>
drexin
added a commit
that referenced
this pull request
May 11, 2021
…37345) * [Concurrency] Reduce overhead of Task.yield and Task.sleep Instead of creating a new task, we create a simple job that wraps a Builtin.RawUnsafeContinuation and resumes the continuation when it is executed. The job instance is allocated on the task local allocator, meaning we don't malloc anything. * Update stdlib/public/Concurrency/Task.swift Co-authored-by: Konrad `ktoso` Malawski <[email protected]> Co-authored-by: Konrad `ktoso` Malawski <[email protected]> Co-authored-by: Konrad `ktoso` Malawski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of creating a new task, we create a simple job that wraps a Builtin.RawUnsafeContinuation and resumes the continuation when it is executed. The job instance is allocated on the task local allocator, meaning we don't malloc anything.