[Property Wrappers] Fix a diagnostic crash when a parameter has a wrapped value mismatch. #37093
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pped value mismatch. If there's an error in property wrapper application, the backing property wrapper type request will return a null type, which would cause the compiler to crash because most error recovery code expects ErrorType. If the wrapper application has an error, use the interface type of the parameter instead.
|
@swift-ci please smoke test |
xedin
approved these changes
Apr 27, 2021
|
@swift-ci please smoke test macOS platform |
1 similar comment
|
@swift-ci please smoke test macOS platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there's an error in property wrapper application, the backing property wrapper type request will return a null type, which would cause the compiler to crash when the property wrapper is applied to a parameter because most error recovery code expects
ErrorType. If the wrapper application has an error, use the interface type of the parameter instead.Resolves: SR-14305