Skip to content

[Concurrency] Harden async_task_async_let_child_cancel so it does not need sleep #37108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ktoso
Copy link
Contributor

@ktoso ktoso commented Apr 28, 2021

This should make the test more resilient on slow platforms where the sleep was not enough to force the expected ordering.

@ktoso
Copy link
Contributor Author

ktoso commented Apr 28, 2021

@swift-ci please smoke test

@ktoso ktoso requested a review from aschwaighofer April 28, 2021 13:47
@ktoso ktoso added the concurrency Feature: umbrella label for concurrency language features label Apr 28, 2021
@ktoso
Copy link
Contributor Author

ktoso commented Apr 28, 2021

@swift-ci please smoke test macOS
@swift-ci please smoke test windows platform

@ktoso
Copy link
Contributor Author

ktoso commented Apr 28, 2021

@swift-ci please smoke test macOS Platform

@ktoso
Copy link
Contributor Author

ktoso commented Apr 29, 2021

windows: T:\Library\Developer\Toolchains\unknown-Asserts-development.xctoolchain\usr\lib\swift\shims/SwiftStdint.h:28:10: error: could not build module 'visualc' weird hm...

@ktoso ktoso merged commit 22c0887 into swiftlang:main Apr 29, 2021
@ktoso ktoso deleted the wip-async_task_async_let_child_cancel-without-sleep branch April 29, 2021 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
concurrency Feature: umbrella label for concurrency language features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant