[Refactoring] Convert completion handler when converting function to async #37110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
force-pushed
the
pr/convert-completion-handler
branch
from
95b29be to
f58f4c5
Compare
|
@swift-ci Please test |
bnbarham
approved these changes
Apr 29, 2021
| // RUN: %refactor -convert-to-async -dump-text -source-filename %s -pos=%(line+1):3 | %FileCheck -check-prefix=PROTO-MEMBER-TO-ASYNC %s | ||
| // RUN: %refactor -convert-to-async -dump-text -source-filename %s -pos=%(line+1):3 | %FileCheck -check-prefix=PROTO-MEMBER %s |
There was a problem hiding this comment.
Is there a test that checks that it does actually convert and not add anywhere? See the top of this file for an example (it's for add-async, convert should have an actual range rather than a 0 length one).
There was a problem hiding this comment.
I don’t think so. I’ll add one in a follow-up PR.
|
@swift-ci Please test Windows |
…async Convert function to async currently only adds "async" to the function and runs the convert call refactoring on the body. This was intentional, but it turns out to be somewhat confusing. Instead, run the same refactoring as the add async alternative refactoring but just replace rather than add. Resolves rdar://77103049
ahoppen
force-pushed
the
pr/convert-completion-handler
branch
from
f58f4c5 to
b2378a4
Compare
|
@swift-ci Please test |
|
Windows failures is unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert function to async currently only adds "async" to the function and runs the convert call refactoring on the body.
This was intentional, but it turns out to be somewhat confusing. Instead, run the same refactoring as the add async alternative refactoring but just replace rather than add.