[CSSimplify] Allow overload choices with missing labels to be considered for diagnostics #37115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…red for diagnostics Let's make use of a newly added "disable for performance" flag to allow solver to consider overload choices where the only issue is missing one or more labels - this makes it for a much better diagnostic experience without any performance impact for valid code.
|
/cc @xwu |
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
|
@shahmishal Debug suite failed with |
|
@swift-ci please test source compatibility debug |
cc: @clackary |
hborla
approved these changes
Apr 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a new constraint flag - "disable for performance" and use it to
allow solver to consider overload choices where the only issue is
missing one or more labels - this makes it for a much better
diagnostic experience without any performance impact for valid code.
This is a workaround for the problem where
simplifyAppliedOverloadsImpldoes filtering during constraint generation and disabled choices stay that
way permanently since there is no rollback mechanism for changes to
constraint system that happen before solver scopes are involved.