Skip to content

[stdlib][test] Update stdlib abi test docs #37119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 29, 2021
Merged

[stdlib][test] Update stdlib abi test docs #37119

merged 2 commits into from
Apr 29, 2021

Conversation

lorentey
Copy link
Member

This adds some additional documentation on how exactly to keep these tests working.

@lorentey
Copy link
Member Author

@swift-ci test

tbkka
tbkka approved these changes Apr 28, 2021
View reviewed changes
Copy link
Contributor

@tbkka tbkka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, though I would put the admonition to "DO NOT DISABLE" at the very beginning. Build wranglers under pressure to get things moving again won't always read the whole thing.

@lorentey
Copy link
Member Author

@swift-ci test

@lorentey lorentey merged commit 7f537b4 into swiftlang:main Apr 29, 2021
@lorentey lorentey deleted the abi-tests-clarifications branch April 29, 2021 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbkka tbkka tbkka approved these changes

@timvermeulen timvermeulen Awaiting requested review from timvermeulen

@Catfish-Man Catfish-Man Awaiting requested review from Catfish-Man

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lorentey @tbkka