DeadObjectAllocation: fix a use-after free crash #37127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
atrick
requested changes
Apr 29, 2021
There was a problem hiding this comment.
You're deliberately creating a data structure full of dangling pointers, whose memory may be reused? And not even commenting that the data structure holds dangling pointers?
The pattern used everywhere else is to use a deletion callback that either removes items from the allocations set or defers deletion.
The optimization tried to optimized a keypath instruction which was already deleted in a previous iteration. rdar://77180080
eeckstein
force-pushed
the
fix-deadobject-elim
branch
from
a60ea38 to
5a76154
Compare
|
Both patterns don't work very well here (I don't want to go into details now). I pushed a new version which I think is a more elegant solution. |
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The optimization tried to optimized a keypath instruction which was already deleted in a previous iteration.
rdar://77180080