Skip to content

[AST] Mark @completionHandlerAsync user-inaccessible #37146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

hamishknight
Copy link
Contributor

This attribute is only really useful to the compiler, so don't expose it to the user through e.g generated interfaces.

Resolves rdar://76685011

This attribute is only really useful to the
compiler, so don't expose it to the user through
e.g generated interfaces.

Resolves rdar://76685011
@hamishknight
Copy link
Contributor Author

@swift-ci please test

@hamishknight
Copy link
Contributor Author

Actually, user-inaccessible isn't what we want here as it'll also block things like code completion...

@bnbarham bnbarham self-requested a review April 29, 2021 22:45
@DougGregor DougGregor merged commit 909218b into swiftlang:main Apr 30, 2021
@bnbarham
Copy link
Contributor

@DougGregor this isn't the correct fix - we should instead mark the ObjC attribute as implicit. This change will:
a) Stop @completionHandlerAsync from appearing in code completion
b) Not show @completionHandlerAsync added in Swift code

I believe @hamishknight was most of the way finished with that change.

Can we revert?

@DougGregor
Copy link
Member

Oh, I jumped the gun. We can revert as part of making it implicit, sure, but I'd rather be in the now-merged state than the state prior to the merge. User-inaccessible is more "hidden" than "not usable", and only really hides the attribute from printing and code completion.

@hamishknight
Copy link
Contributor Author

Yeah sorry for the confusion – I was meaning to update this PR but ran out of time in the day. Opened a PR for the proper fix: #37170

@hamishknight hamishknight deleted the completion-handler-async-interface branch April 30, 2021 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants