[5.5] Mark imported @completionHandlerAsync attrs as implicit #37172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is too extreme, as we still want the attribute to appear in things like code completion and generated interfaces if it was explicitly written by the user. Reverts a2b5f68, but keeps the test case intact.
Mark imported `@completionHandlerAsync` attrs as implicit, which avoids printing them in generated interfaces. And for the sake of completion, serialize the implicit bit in case it's used elsewhere in the future. To make sure we continue to print `@completionHandlerAsync` attributes explicitly written by the user in Swift, add a SourceKit interface test. Resolves rdar://76685011
Now that @completionHandlerAsync is implicit for imported decls, we need to enable implicit attrs in a couple of tests that are testing its presence.
|
@swift-ci please test |
akyrtzi
approved these changes
Apr 30, 2021
|
Build failed |
|
Failure is unrelated: |
AnthonyLatsis
added
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
5.5 cherry-pick of #37170
Marking the attribute user-inaccessible is too extreme, as we still want it to appear in things like code completion and generated interfaces if it was explicitly written by the user. Instead, mark the attribute as implicit when it's added by the Clang Importer, which stops it from being printed in the generated interface.
In addition, fix a typo with the printing of
@completionHandlerAsync.Resolves rdar://76685011.