Skip to content

Add missing _Concurrency dependency to the Dispatch overlay #37186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 11, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions stdlib/public/Darwin/Dispatch/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,10 @@ add_swift_target_library(swiftDispatch ${SWIFT_SDK_OVERLAY_LIBRARY_BUILD_TYPES}

SWIFT_COMPILE_FLAGS ${SWIFT_RUNTIME_SWIFT_COMPILE_FLAGS} ${SWIFT_STANDARD_LIBRARY_SWIFT_FLAGS}
LINK_FLAGS "${SWIFT_RUNTIME_SWIFT_LINK_FLAGS}"
SWIFT_MODULE_DEPENDS_OSX Darwin ObjectiveC # auto-updated
SWIFT_MODULE_DEPENDS_IOS Darwin ObjectiveC # auto-updated
SWIFT_MODULE_DEPENDS_TVOS Darwin ObjectiveC # auto-updated
SWIFT_MODULE_DEPENDS_WATCHOS Darwin ObjectiveC # auto-updated
SWIFT_MODULE_DEPENDS_OSX _Concurrency Darwin ObjectiveC # auto-updated
SWIFT_MODULE_DEPENDS_IOS _Concurrency Darwin ObjectiveC # auto-updated
SWIFT_MODULE_DEPENDS_TVOS _Concurrency Darwin ObjectiveC # auto-updated
SWIFT_MODULE_DEPENDS_WATCHOS _Concurrency Darwin ObjectiveC # auto-updated
FRAMEWORK_DEPENDS_WEAK Combine

DEPLOYMENT_VERSION_OSX ${SWIFTLIB_DEPLOYMENT_VERSION_DISPATCH_OSX}
Expand Down
13 changes: 13 additions & 0 deletions test/Unit/lit.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -77,3 +77,16 @@ config.test_format = lit.formats.GoogleTest(config.build_mode, 'Tests')
# module cache for all those tests that do not set that explicitly
if 'XDG_CACHE_HOME' in os.environ:
config.environment['XDG_CACHE_HOME'] = os.environ['XDG_CACHE_HOME']

# Find the resource directory. Assume it's near the swift compiler if not set.
test_resource_dir = lit_config.params.get('test_resource_dir')
if not test_resource_dir:
test_resource_dir = config.swiftlib_dir

if 'use_os_stdlib' not in lit_config.params:
# Ensure we load the libraries from the just built compiler
# when building on Darwin
# This is needed in addition to what is done in `add_swift_unittest`
# to handle dependencies of the dylibs loaded by `SwiftRuntimeTests`
# (for which we cannot run `swift-rpathize.py`)
config.environment['DYLD_LIBRARY_PATH'] = os.path.join(test_resource_dir, 'macosx')
1 change: 1 addition & 0 deletions test/Unit/lit.site.cfg.in
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ config.llvm_libs_dir = "@LLVM_LIBS_DIR@"
config.build_mode = lit_config.params.get('build_mode', "@SWIFT_BUILD_MODE@")
config.swift_obj_root = "@SWIFT_BINARY_DIR@"
config.target_triple = "@TARGET_TRIPLE@"
config.swiftlib_dir = "@LIT_SWIFTLIB_DIR@"
config.swift_test_results_dir = \
lit_config.params.get("swift_test_results_dir", "@SWIFT_TEST_RESULTS_DIR@")

Expand Down
2 changes: 1 addition & 1 deletion unittests/runtime/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ if(("${SWIFT_HOST_VARIANT_SDK}" STREQUAL "${SWIFT_PRIMARY_VARIANT_SDK}") AND
# some stdlib hooks to implement SwiftObject.
list(APPEND PLATFORM_TARGET_LINK_LIBRARIES
${FOUNDATION_LIBRARY}
swift_Concurrency${SWIFT_PRIMARY_VARIANT_SUFFIX}
swiftStdlibUnittest${SWIFT_PRIMARY_VARIANT_SUFFIX}
)
elseif(SWIFT_HOST_VARIANT STREQUAL "Linux")
Expand Down Expand Up @@ -129,4 +130,3 @@ if(("${SWIFT_HOST_VARIANT_SDK}" STREQUAL "${SWIFT_PRIMARY_VARIANT_SDK}") AND
${PLATFORM_TARGET_LINK_LIBRARIES}
)
endif()