Restore operator '+' family for UnsafePointer. #3719
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reverts part of my previous patch. Removing the operators is too much of a performance penalty to take. The difference is that the Strideable operators are not transparent. I still need to remove the UnsafeRawPointer operators, so -Onone performance will be bad in some cases until this is fixed: <rdar://problem/27513184> [perf] Strideable operators are not transparent. This is a huge -Onone performance penalty.
|
@swift-ci Please smoke test and merge. |
|
This failed on swap_refcnt. I think it's safe to merge now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reverts part of my previous patch. Removing the operators is too much of a
performance penalty to take. The difference is that the Strideable operators are
not transparent.
I still need to remove the UnsafeRawPointer operators, so -Onone performance
will be bad in some cases until this is fixed:
rdar://problem/27513184 [perf] Strideable operators are not transparent. This is a huge -Onone performance penalty.