Skip to content

[Concurrency] don't require Sendable (yet) #37197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 3, 2021
Merged

[Concurrency] don't require Sendable (yet) #37197

merged 1 commit into from
May 3, 2021

Conversation

ktoso
Copy link
Contributor

@ktoso ktoso commented May 1, 2021 •
edited
Loading

We should not be enforcing Sendable usage (yet), so we need to remove the requirements from task group type parameters

This removes the requirement from:

  • task groups
  • task locals

@ktoso ktoso requested review from phausler and DougGregor May 1, 2021 02:05
@ktoso ktoso force-pushed the wip-group-dont-require-sendble-yet branch from d9cbaa9 to 05124cf Compare May 1, 2021 02:10
@ktoso ktoso changed the title [TaskGroup] don't require Sendable (yet) [Concurrency] don't require Sendable (yet) May 1, 2021
@ktoso
Copy link
Contributor Author

ktoso commented May 1, 2021

@swift-ci please smoke test and merge

@ktoso ktoso force-pushed the wip-group-dont-require-sendble-yet branch 2 times, most recently from be4280c to a0a807b Compare May 1, 2021 07:29
@ktoso
Copy link
Contributor Author

ktoso commented May 1, 2021

@swift-ci please smoke test and merge

phausler
phausler approved these changes May 1, 2021
View reviewed changes
Copy link
Contributor

@phausler phausler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This totally resolves some of the issues I was seeing. I presume there will likely be some magic later on to add requirements for these later when it is ready?

@phausler
Copy link
Contributor

phausler commented May 1, 2021

Seems like the unit tests for task_local.swift:27 still have the requirement on them.

@ktoso ktoso force-pushed the wip-group-dont-require-sendble-yet branch from a0a807b to 1cd7180 Compare May 3, 2021 01:52
@ktoso
Copy link
Contributor Author

ktoso commented May 3, 2021

I presume there will likely be some magic later on to add requirements for these later when it is ready?

Yeah, Doug claims he has a plan for that, I don't know the details though/

@ktoso
Copy link
Contributor Author

ktoso commented May 3, 2021

@swift-ci please smoke test and merge

@swift-ci swift-ci merged commit a6915e7 into swiftlang:main May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phausler phausler phausler approved these changes

@DougGregor DougGregor Awaiting requested review from DougGregor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ktoso @phausler @swift-ci