Fixits for @noreturn -> Never (SE-0102) #3720
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
|
Cool! Thanks for making migration easy for users, Slava! |
slavapestov
force-pushed
the
migrate-noreturn-to-never
branch
from
aed45cd to
0b7681f
Compare
|
@swift-ci Please test and merge |
There are two places where @NoReturn appears: - As an attribute on function declarations - As an attribute on function types In the first case, we have to handle a few different cases; the function declaration might not have a return type, or it might be something other than ().
slavapestov
force-pushed
the
migrate-noreturn-to-never
branch
from
0b7681f to
e5f1d73
Compare
|
@swift-ci Please test |
| of ``@noreturn`` functions. An ``unreachable`` instruction that survives | ||
| guaranteed DCE and is not immediately preceded by a ``@noreturn`` | ||
| of functions returning uninhabited types. An ``unreachable`` instruction that | ||
| survives guaranteed DCE and is not immediately preceded by an no-return |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces migration from @NoReturn to returning Never, and removes old code for the @NoReturn attribute now that it has become an error.