[NFC][Sema] Changing API to facilitate recording pontential holes recursively #37209
+22
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool @swift-ci test |
|
Build failed |
|
@swift-ci please test Linux platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just noted while looking up another issue that there are quite few points where we use the same
visitpattern to record holes recursively, but since we changedrecordPotentialHolesome time ago to do that already, we could remove thosevisitpatterns. One thing to improve clarity at call site I try to makerecordPotentialHoleback to take aTypeVarTypeand created a newrecordAnyTypeVarAsPotentialHole(maybe we can think about a better name) that takes a type avisitrecording for all type variable within the type.So let me know if this makes sense :)
Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.