ModuleLoader: teach canImport to check Swift user module versions #37219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
nkcsgexi
force-pushed
the
73992299-4
branch
2 times, most recently
from
1dac869 to
da197b3
Compare
|
@swift-ci please smoke test |
For config condition `canImport(Foo, version: N)`, this patch teaches the compiler to check N against the version of the Swift module Foo on disk. It returns true if the module version on disk is greater or equal to N and returns false otherwise. Part of rdar://73992299
|
@swift-ci please smoke test |
|
@swift-ci Please smoke test OS X platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For config condition
canImport(Foo, version: N), this patch teaches the compiler to check Nagainst the version of the Swift module Foo on disk. It returns true if the module version on
disk is greater or equal to N and returns false otherwise.
Part of rdar://73992299