-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[Serialization] Add warning when .swiftsourceinfo is malformed #37237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Output a warning rather than ignoring a malformed .swiftsourceinfo completely. Resolves rdar://77350048
@swift-ci please test |
Build failed |
Build failed |
The change to remove ignoring .swiftsourceinfo by default wasn't in 5.5 yet, it is now. @swift-ci please test |
Build failed |
Unrelated failure, looks like it should be fixed now @swift-ci please test macOS platform |
Looks like the Windows failure is fixed now too. @swift-ci please test Windows platform |
@swift-ci please nominate --- CCC --- Explanation: Outputs a warning when reading a malformed .swiftsourceinfo, rather than completely ignoring it. The most common case would be an old version. Even this would be unusual as the .swiftmodule would normally be out-of-date as well, causing both to be rebuilt. In case this does happen, however, this warning will help with diagnosing stale data in SourceKit responses. Radar/SR Issue: rdar://77350048 Risk: Very minimal. At most there's a risk of a spuriously outputting the new diagnostic warning. Testing: Added a test case for loading invalid .swiftsourceinfo files. |
Build failed |
Still unrelated @swift-ci please test macOS platform |
Cherry-pick #37196:
Output a warning rather than ignoring a malformed .swiftsourceinfo
completely.
Resolves rdar://77350048