[5.5][AST] Don’t print internal function labels if they start with '$' #37239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We might infer internal function labels as `$0` from a closure with which a variable is initialised. But we don’t want to print the function signature as `(_ $0: Int) -> Int` because `$0` is not a valid variable name to declare. So, in the case described above, only print the type. Fixes rdar://77462547
|
@swift-ci Please test |
ahoppen
changed the title
|
Build failed |
|
This looks good, thank you! @swift-ci Please smoke test macOS |
xymus
approved these changes
May 4, 2021
akyrtzi
approved these changes
May 4, 2021
|
@swift-ci Please test macOS |
|
@swift-ci Please test Windows |
AnthonyLatsis
added
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picks #37238 to 5.5
We might infer internal function labels as
$0from a closure with which a variable is initialised. But we don’t want to print the function signature as(_ $0: Int) -> Intbecause$0is not a valid variable name to declare.So, in the case described above, only print the type.
Fixes rdar://77462547