[TypeChecker] NFC: Add a test-case for expression affected by rdar://61749633 #37246
Conversation
|
@swift-ci please smoke test |
|
@swift-ci please smoke test Windows platform |
test/Constraints/subscript.swift
Outdated
| } | ||
|
|
||
| func test(a: A?) { | ||
| let _ = a?[A] // Ok |
There was a problem hiding this comment.
Did we accept this by mistake? I guess we should at least warn about the missing “.self” instead of making it an error
There was a problem hiding this comment.
Yes, I think it was just an oversight but fixing a crash make this fail to type-check suggesting .self which is a source compatibility regression unfortunately... I'll try to figure out how to make it a warning in MiscDiagnostics but for that I'd need access to whole parent AST and not just an immediate parent expr...
There was a problem hiding this comment.
Once revert of a revert lands I'm going to adjust this to report an error with a fix-it.
There was a problem hiding this comment.
Revert has been merged and test-case is now going to fail with fix-its.
xedin
force-pushed
the
test-case-for-valid-type-arg-of-subscript
branch
from
a76e904 to
3b54fdb
Compare
xedin
changed the title
|
@swift-ci please smoke test |
|
@swift-ci please smoke test macOS platform |
No description provided.