Skip to content

[SR-14135]Updating diagnostic message for convenience init in struct #37267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 5, 2021

Conversation

kaar3k
Copy link
Contributor

@kaar3k kaar3k commented May 5, 2021

struct Foo {
    let code: String

    convenience init(someCode: String) {    // error: delegating initializers in structs are not marked with 'convenience' 
        self.init(code: someCode)
    }

    init(code: String) {
        self.code = code
    }
}

Updating the above error message to initializers in structs are not marked with 'convenience'

@kaar3k
Copy link
Contributor Author

kaar3k commented May 5, 2021

@swift-ci Please smoke test Linux platform

@varungandhi-apple
Copy link
Contributor

@swift-ci smoke test and merge

@varungandhi-apple
Copy link
Contributor

New contributors can't immediately run CI since we had some abuse of that system in the past. In the meantime, you can ask someone else to do it for you.

@kaar3k
Copy link
Contributor Author

kaar3k commented May 5, 2021

was not aware about this, will reach out to someone from next time. Thanks for accepting this Varun..

@swift-ci swift-ci merged commit 8d7eede into swiftlang:main May 5, 2021
@varungandhi-apple
Copy link
Contributor

No worries. Could you please mark the JIRA as resolved? Thanks for the contribution! 😄

@kaar3k
Copy link
Contributor Author

kaar3k commented May 6, 2021

Upated Varun 😃. Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants