Skip to content

[test] reenable sanitizer driver tests #37275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 6, 2021
Merged

[test] reenable sanitizer driver tests #37275

merged 1 commit into from
May 6, 2021

Conversation

aralisza
Copy link
Contributor

@aralisza aralisza commented May 5, 2021 •
edited
Loading

reenable select sanitizer tests, they should pass in CI

rdar://64784401
rdar://72514092

@aralisza
Copy link
Contributor Author

aralisza commented May 5, 2021

@swift-ci please test

@aralisza aralisza changed the title [test] reenable sanitizer tests [test] reenable sanitizer driver tests May 5, 2021
@aralisza aralisza requested a review from danliew-apple May 5, 2021 23:47
@danliew-apple
Copy link
Contributor

LGTM

@danliew-apple
Copy link
Contributor

@nkcsgexi Just a heads up that we are re-enabling these tests. @aralisza cannot reproduce failures. If they start failing again please send this to me or @aralisza. If the failure is internal only please only disable there so that this test doesn't get disabled in places where it is passing.

danliew-apple
danliew-apple approved these changes May 5, 2021
View reviewed changes
Copy link
Contributor

@danliew-apple danliew-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nkcsgexi
nkcsgexi approved these changes May 6, 2021
View reviewed changes
Copy link
Contributor

@nkcsgexi nkcsgexi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Do we have equivalent tests in the swift-driver side?

@danliew-apple
Copy link
Contributor

@nkcsgexi Not yet. @aralisza is looking into this.

@aralisza aralisza merged commit 1e6a5f4 into main May 6, 2021
@aralisza aralisza deleted the emily/reenable-test branch May 6, 2021 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkcsgexi nkcsgexi nkcsgexi approved these changes

@danliew-apple danliew-apple danliew-apple approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aralisza @danliew-apple @nkcsgexi